Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

To: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 14 Oct 2018 08:47:53 -0700
Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Michael Schmitz <schmitzmic@xxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <91b9ff9fc19ba40e3a2562171c8cd78a2ce7dc79.1539497520.git.fthain@telegraphics.com.au>
User-agent: Mutt/1.9.2 (2017-12-15)

> +	*p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun);

I think lp should always be non-NULL here.

Follow-Ups:
- Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
  - From: Finn Thain
- Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
  - From: Michael Schmitz

References:
- [PATCH v2 0/6] mac_esp, zorro_esp, esp_scsi: Various improvements
  - From: Finn Thain
- [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
  - From: Finn Thain