On Fri, 12 Oct 2018 09:11:27 -0700, Bart Van Assche wrote: > There have been too many problems with strcpy() and buffer overflows in the > past. If the source and destination strings both have the same size, please > add a BUILD_BUG_ON() statement that verifies that at compile time. If that > not's the case, how about using strlcpy() to make it easy for anyone who > reads the source code that no output buffer overflow will occur? Both arrays are the same size (ISCSI_IQN_LEN). I'll change this over to use strlcpy(), as I agree that it helps readability. Cheers, David
