On Sat, Oct 13, 2018 at 06:22:18PM +1100, Finn Thain wrote: > > > + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP_STATUS)); > > > > This should probably use dev_err (at least with my series). > > > > How about shost_printk()? That would be consistent with the rest of > esp_scsi.c. It also means my series need not depend on yours which would > complicate things. Yes, that sounds even better.