On Sat, 13 Oct 2018, Christoph Hellwig wrote:
> > +#if IS_ENABLED(CONFIG_SCSI_MAC_ESP) || IS_ENABLED(CONFIG_SCSI_ZORRO_ESP)
>
> Please add a new CONFIG_SCSI_ESP_PIO symbol that is selected by
> the mac and zorro drivers instead.
>
OK.
> > + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP_STATUS));
>
> This should probably use dev_err (at least with my series).
>
How about shost_printk()? That would be consistent with the rest of
esp_scsi.c. It also means my series need not depend on yours which would
complicate things.
--
