Re: [PATCH 5/5] esp_scsi: move dma mapping into the core code

[Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>]

On Sat, 13 Oct 2018, Christoph Hellwig wrote:

> On Sat, Oct 13, 2018 at 09:24:51AM +1100, Finn Thain wrote:
> > >  	struct scatterlist *sg = scsi_sglist(cmd);
> > > -	int dir = cmd->sc_data_direction;
> > > -	int total, i;
> > > +	int total = 0, i;
> > >  
> > > -	if (dir == DMA_NONE)
> > > -		return;
> > > -
> > 
> > Removing this DMA_NONE test caused an oops in my test. sg becomes a NULL 
> > pointer.
> 
> Does it work if you add the check back?
> 

Yes.

--