On Thu, 2018-08-02 at 11:10 +-0800, zhong jiang wrote: +AD4- The same check condition is redundant, so remove one of them. +AD4- +AD4- Signed-off-by: zhong jiang +ADw-zhongjiang+AEA-huawei.com+AD4- +AD4- --- +AD4- drivers/scsi/NCR5380.c +AHw- 3 +--- +AD4- 1 file changed, 1 insertion(+-), 2 deletions(-) +AD4- +AD4- diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c +AD4- index 90ea0f5..2ecaf3f 100644 +AD4- --- a/drivers/scsi/NCR5380.c +AD4- +-+-+- b/drivers/scsi/NCR5380.c +AD4- +AEAAQA- -999,8 +-999,7 +AEAAQA- static struct scsi+AF8-cmnd +ACo-NCR5380+AF8-select(struct Scsi+AF8-Host +ACo-instance, +AD4- +AD4- /+ACo- Check for lost arbitration +ACo-/ +AD4- if ((NCR5380+AF8-read(INITIATOR+AF8-COMMAND+AF8-REG) +ACY- ICR+AF8-ARBITRATION+AF8-LOST) +AHwAfA- +AD4- - (NCR5380+AF8-read(CURRENT+AF8-SCSI+AF8-DATA+AF8-REG) +ACY- hostdata-+AD4-id+AF8-higher+AF8-mask) +AHwAfA- +AD4- - (NCR5380+AF8-read(INITIATOR+AF8-COMMAND+AF8-REG) +ACY- ICR+AF8-ARBITRATION+AF8-LOST)) +AHs- +AD4- +- (NCR5380+AF8-read(CURRENT+AF8-SCSI+AF8-DATA+AF8-REG) +ACY- hostdata-+AD4-id+AF8-higher+AF8-mask)) +AHs- +AD4- NCR5380+AF8-write(MODE+AF8-REG, MR+AF8-BASE)+ADs- +AD4- dsprintk(NDEBUG+AF8-ARBITRATION, instance, +ACI-lost arbitration, deasserting MR+AF8-ARBITRATE+AFw-n+ACI-)+ADs- +AD4- spin+AF8-lock+AF8-irq(+ACY-hostdata-+AD4-lock)+ADs- Has this patch been tested? Thanks, Bart.
