On Thu, 2018-08-02 at 10:45 +-0800, zhong jiang wrote: +AD4- doulbe test in a expression is redundant. so just remove one of +AD4- them. +AD4- +AD4- Signed-off-by: zhong jiang +ADw-zhongjiang+AEA-huawei.com+AD4- +AD4- --- +AD4- drivers/scsi/qla1280.c +AHw- 1 - +AD4- 1 file changed, 1 deletion(-) +AD4- +AD4- diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c +AD4- index 390775d..8e6f156 100644 +AD4- --- a/drivers/scsi/qla1280.c +AD4- +-+-+- b/drivers/scsi/qla1280.c +AD4- +AEAAQA- -1504,7 +-1504,6 +AEAAQA- static void qla1280+AF8-mailbox+AF8-timeout(struct timer+AF8-list +ACo-t) +AD4- /+ACo- Issue SCSI reset, if we can't reset twice then bus is dead +ACo-/ +AD4- for (bus +AD0- 0+ADs- bus +ADw- ha-+AD4-ports+ADs- bus+-+-) +AHs- +AD4- if (+ACE-ha-+AD4-bus+AF8-settings+AFs-bus+AF0-.disable+AF8-scsi+AF8-reset +ACYAJg- +AD4- - qla1280+AF8-bus+AF8-reset(ha, bus) +ACYAJg- +AD4- qla1280+AF8-bus+AF8-reset(ha, bus)) +AD4- ha-+AD4-bus+AF8-settings+AFs-bus+AF0-.scsi+AF8-bus+AF8-dead +AD0- 1+ADs- +AD4- +AH0- Same question here: does qla1280+AF8-bus+AF8-reset() have any side effects? Bart.
