On Sun, Jul 15, 2018 at 06:16:24PM -0500, Mike Christie wrote: > For tcm_fc, it should be ok to call > transport_deregister_session_configfs later like in the new > remove function because the transport_deregister_session_configfs call > was not affecting the target_sess_cmd_list_set_waiting/ > target_wait_for_sess_cmds calls and nothing else was being > torn down between that time. > > For drivers that only called transport_deregister_session > the new remove function that calls transport_deregister_session_configfs > should be ok, because those drivers did not access se_nacl->nacl_sess > or sess_acl_list so they will see no difference. It might be worth to split the conversion of the drivers that didn't exactly call transport_deregister_session_configfs + transport_deregister_session into a separate per-driver patch to better document this. Except for that this looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
