Hello Christoph, Thank you for the review of the patches. With implementation of tasklet in the driver we see a performance increase of about 8%, so we decided to go with it. Regards, Sumant -----Original Message----- From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] Sent: Thursday, September 21, 2006 4:46 AM To: Patro, Sumant Cc: James.Bottomley@xxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; hch@xxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Kolli, Neela; Yang, Bo Subject: Re: [Patch 6/7] megaraid_sas: adds tasklet for cmd completion On Wed, Sep 20, 2006 at 07:31:29PM -0700, Sumant Patro wrote: > This patch adds a tasklet for command completion. Why would you need this? The normal scsi command completion is offloaded to the SCSI softirq ASAP so I don't see any point for those. Do you see too much time spent in completion of the internal commands? - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html