> > On Thu, Jul 05, 2018 at 05:42:02PM +0000, Dave Carroll wrote: > > > Remove the AAC_STAT_GOOD definition and open code it in the places > > > it was used. > > > > > > This will make subsequent refactoring in this area easier. > > > > > Please don't ... the definition itself was added to make refactoring easier. > > Well in the end scsi_cmnd::result as we know it currently will go away, so > splitting up the define is rather crucial for this. I could do it when changing the - > >result from one integer into 4 u8s but doing it in a separate preparation step > would be preferable to me and it doesn't hurt accraid at all. > Thanks for the explanation Johannes, the routine is unwieldy already, and it just didn't feel right adding back all those lines ... Looking forward to the next step ... Reviewed-by: Dave Carroll <david.carroll@xxxxxxxxxxxxx>
