On Thu, Jul 05, 2018 at 05:42:02PM +0000, Dave Carroll wrote: > > Remove the AAC_STAT_GOOD definition and open code it in the places it was > > used. > > > > This will make subsequent refactoring in this area easier. > > > Please don't ... the definition itself was added to make refactoring easier. Well in the end scsi_cmnd::result as we know it currently will go away, so splitting up the define is rather crucial for this. I could do it when changing the ->result from one integer into 4 u8s but doing it in a separate preparation step would be preferable to me and it doesn't hurt accraid at all. For more information please see [1] and [2]. A first preparation series [3] has already landed upstream. [1] https://marc.info/?l=linux-scsi&m=152300071418035&w=2 [2] https://marc.info/?l=linux-scsi&m=152406381222604&w=2 [3] https://marc.info/?l=linux-scsi&m=152887646121085&w=2 Thanks, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
