Re: [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ar Llu, 2006-09-18 am 20:01 +0100, ysgrifennodd Christoph Hellwig:
> NACK.  This doesn't help us forward at all.  In case you have
> the hardware please do a full conversion to the real pci probing API.

Then please mark every SCSI user of pci_find_device() as && BROKEN and
delete them in 6 months because I want to remove pci_find_device because
its a hazard. The patch I proposed ensures the driver doesn't crash the
box iterating the list unsafely. If you won't accept safe iteration the
driver should be deleted. 

I guess the other alternative would be to add !HOTPLUG to all the
offenders and remove pci_find_device if hotplug is enabled.

Be honest - nobody is ever going to convert that driver or the other
ancient scsi drivers or the serial drivers to the pci module API even if
you play political games NAKing other fixes to try and make it happen. 

James - what would you prefer - removal, && BROKEN, && !HOTPLUG or at
least fixing one thing that needs a fix ?

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux