On Thu, 24 May 2018 21:09:01 -0700 James Smart <jsmart2021@xxxxxxxxx> wrote: > The driver exits port setup after failing the > lpfc_sli4_get_parameters command (messages 0356, 2541, & 1412). > > The older CNA adapters do not support the MBX command. In the past > the code was allowed to fail and continue on with initialization. > However a nvme change moved a closing bracket and now makes all > failures terminal. > > Revise the logic so that terminal failure only occurs if the command > failed on the newer adapters. Additionally, if parameters are set > that require information from the command and the command failed, > the parameters are erroneous and port set up should fail even on > the older adapters. > > Signed-off-by: Dick Kennedy <dick.kennedy@xxxxxxxxxxxx> > Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx> > --- > drivers/scsi/lpfc/lpfc_init.c | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes