On 2018/5/24 16:18, Sebastian Andrzej Siewior wrote:
On 2018-05-24 16:00:47 [+0800], Jason Yan wrote:
Because you are trying to delete the irq-save code which will make the
comment hard to understand, I'm just giving an advise. It's welcome
if you have a better way.
I am removing local_irq_save() prior an unlock of a lock which has to be
taken with disabled interrupts. Therefore the interrupts are disabling
as part of the locking procedure and the additional disabling is a nop.
What comment are you talking about? sas_ata_qc_issue() has no comments
except for "If the device fell …".
I mean the "TODO" comment above the local_irq_save().
this?
/*
* The local_irq_*() APIs are equal to the raw_local_irq*()
* if !TRACE_IRQFLAGS.
*/
NO, this:
/* TODO: audit callers to ensure they are ready for qc_issue to
* unconditionally re-enable interrupts
*/
local_irq_save(flags);
spin_unlock(ap->lock);
Sebastian
.
