On 2018-05-24 16:00:47 [+0800], Jason Yan wrote: > > > Because you are trying to delete the irq-save code which will make the > > > comment hard to understand, I'm just giving an advise. It's welcome > > > if you have a better way. > > > > I am removing local_irq_save() prior an unlock of a lock which has to be > > taken with disabled interrupts. Therefore the interrupts are disabling > > as part of the locking procedure and the additional disabling is a nop. > > > > What comment are you talking about? sas_ata_qc_issue() has no comments > > except for "If the device fell …". > > > > I mean the "TODO" comment above the local_irq_save(). this? /* * The local_irq_*() APIs are equal to the raw_local_irq*() * if !TRACE_IRQFLAGS. */ Sebastian
