Hi Geert,
On Wed, Apr 11, 2018 at 8:56 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> Hi Michael,
>
> On Wed, Apr 11, 2018 at 10:36 AM, Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
>> From: Michael Schmitz <schmitz@xxxxxxxxxx>
>>
>> New combined SCSI driver for all ESP based Zorro SCSI boards for
>> m68k Amiga.
>
> Thanks a lot!
My pleasure entirely.
>
>> --- /dev/null
>> +++ b/drivers/scsi/zorro_esp.c
>
>> +static const struct zorro_device_id zorro_esp_zorro_tbl[] = {
>> + { /* Blizzard 1230 IV */
>> + .id = ZORRO_ID(PHASE5, 0x11, 0),
>> + .driver_data = (unsigned long)ZORRO_BLZ1230,
>
> These casts are not needed if ZORRO_BLZ1230 is an enum.
Oh dear - meant to check that but forgot in the end. I'll respin.
Cheers,
Michael
>
>> +static int zorro_esp_probe(struct zorro_dev *z,
>> + const struct zorro_device_id *ent)
>> +{
>> + struct scsi_host_template *tpnt = &scsi_esp_template;
>> + struct Scsi_Host *host;
>> + struct esp *esp;
>> + const struct zorro_driver_data *zdd;
>> + struct zorro_esp_priv *zep;
>> + unsigned long board, ioaddr, dmaaddr;
>> + int err;
>> +
>> + board = zorro_resource_start(z);
>> + zdd = &zorro_esp_boards[(unsigned long)ent->driver_data];
>
> likewise
>
>> + if (zep->zorro3 && ent->driver_data == (unsigned long)ZORRO_BLZ1230II) {
>
> likewise
>
>> + if (zep->zorro3 && ent->driver_data == (unsigned long)ZORRO_BLZ1230II) {
>
> one more
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
