Re: [PATCH v8] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

On Wed, Apr 11, 2018 at 10:36 AM, Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
> From: Michael Schmitz <schmitz@xxxxxxxxxx>
>
> New combined SCSI driver for all ESP based Zorro SCSI boards for
> m68k Amiga.

Thanks a lot!

> --- /dev/null
> +++ b/drivers/scsi/zorro_esp.c

> +static const struct zorro_device_id zorro_esp_zorro_tbl[] = {
> +       {       /* Blizzard 1230 IV */
> +               .id = ZORRO_ID(PHASE5, 0x11, 0),
> +               .driver_data = (unsigned long)ZORRO_BLZ1230,

These casts are not needed if ZORRO_BLZ1230 is an enum.

> +static int zorro_esp_probe(struct zorro_dev *z,
> +                                      const struct zorro_device_id *ent)
> +{
> +       struct scsi_host_template *tpnt = &scsi_esp_template;
> +       struct Scsi_Host *host;
> +       struct esp *esp;
> +       const struct zorro_driver_data *zdd;
> +       struct zorro_esp_priv *zep;
> +       unsigned long board, ioaddr, dmaaddr;
> +       int err;
> +
> +       board = zorro_resource_start(z);
> +       zdd = &zorro_esp_boards[(unsigned long)ent->driver_data];

likewise

> +       if (zep->zorro3 && ent->driver_data == (unsigned long)ZORRO_BLZ1230II) {

likewise

> +       if (zep->zorro3 && ent->driver_data == (unsigned long)ZORRO_BLZ1230II) {

one more

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux