Re: [PATCH] fix scsi_send_eh_cmnd regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 26, 2006 at 03:00:22AM -0400, Mike Christie wrote:
> The callers of scsi_send_eh_cmnd are setting the cmnd buffer,
> and then scsi_send_eh_cmnd is copying that updated buffer to
> the old_cmnd variable. Then after the command runs, we end up
> copying that old_cmnd var which has the new cmnd to the scsi
> command buffer. When this command gets recent, all types of fun
> things happen like getting TUR or START_STOP commands with
> data and scatterlists.
> 
> This patch made against scsi-rc-fixes, has the callers of
> scsi_send_eh_cmnd pass in the command so scsi_send_eh_cmnd
> can do the right thing. This should go into 2.6.18 since this
> fixes a regression added when we removed some of the scsi_cmnd
> fields and replaced them with local variables.

Ok.  Thanks a lot for fixing this.

I really wish we had something like a regression test suite to find
things like this..
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux