On Mon, Aug 21, 2006 at 08:25:48PM +0100, Russell King wrote:
> On Mon, Aug 21, 2006 at 09:22:15PM +0200, Adrian Bunk wrote:
> > On Mon, Aug 21, 2006 at 11:53:44AM +0100, Christoph Hellwig wrote:
> > > On Mon, Aug 21, 2006 at 12:43:57PM +0200, Adrian Bunk wrote:
> > > > This patch contains the following cleanups:
> > > > - #include <linux/irq.h> for getting the prototypes of
> > > > {dis,en}able_irq()
> > >
> > > nothing outside of arch code must ever include <linux/irq.h>
> >
> > Why?
> > It sounds rather strange that non-arch code should use asm headers.
>
> Still the wrong header. <linux/interrupt.h> is what you're looking for.
>
> $ grep '\(en\|dis\)able_irq' include/linux/interrupt.h
> extern void disable_irq_nosync(unsigned int irq);
> extern void disable_irq(unsigned int irq);
> extern void enable_irq(unsigned int irq);
> static inline void disable_irq_nosync_lockdep(unsigned int irq)
> disable_irq_nosync(irq);
> static inline void disable_irq_lockdep(unsigned int irq)
> disable_irq(irq);
> static inline void enable_irq_lockdep(unsigned int irq)
> enable_irq(irq);
> static inline int enable_irq_wake(unsigned int irq)
> static inline int disable_irq_wake(unsigned int irq)
> # define disable_irq_nosync_lockdep(irq) disable_irq_nosync(irq)
> # define disable_irq_lockdep(irq) disable_irq(irq)
> # define enable_irq_lockdep(irq) enable_irq(irq)
Unfortunately, it isn't:
<-- snip -->
...
#ifdef CONFIG_GENERIC_HARDIRQS
extern void disable_irq_nosync(unsigned int irq);
extern void disable_irq(unsigned int irq);
extern void enable_irq(unsigned int irq);
...
<-- snip -->
> Russell King
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
