Re: [PATCH v2 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2018/1/4 20:41, Christoph Hellwig wrote:
On Thu, Jan 04, 2018 at 07:47:41PM +0800, Jason Yan wrote:
+	phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1;

missing whitespaces around the ":, but this could just be simplified to:

	phy->phy->enabled = (phy->linkrate != SAS_PHY_DISABLED);


That's better, will update. Thanks.

Otherwise this looks fine.

.





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux