Re: [PATCH v2 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER

[Jason Yan <yanaijie@xxxxxxxxxx>]

On 2018/1/4 20:41, Christoph Hellwig wrote:
> On Thu, Jan 04, 2018 at 07:47:41PM +0800, Jason Yan wrote:
> > +	phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1;
>
> missing whitespaces around the ":, but this could just be simplified to:
>
> 	phy->phy->enabled = (phy->linkrate != SAS_PHY_DISABLED);

That's better, will update. Thanks.

> Otherwise this looks fine.
>
> .