On Thu, Jan 04, 2018 at 07:47:41PM +0800, Jason Yan wrote: > + phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1; missing whitespaces around the ":, but this could just be simplified to: phy->phy->enabled = (phy->linkrate != SAS_PHY_DISABLED); Otherwise this looks fine.