Re: [PATCH] scsi: fix iscsi-related kernel-doc warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/03/2018 08:11 PM, Martin K. Petersen wrote:
> 
> Randy,
> 
>> Fix kernel-doc warnings in drivers/scsi/ that are related to iscsi
>> support interfaces.
>>
>> Fixes these kernel-doc warnings: (tested by adding these files to a new
>> target.rst documentation file: WIP)
> 
> Applied to 4.16/scsi-queue, thanks!
> 
>> Cc:	"Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>
>> Cc:	linux-scsi@xxxxxxxxxxxxxxx
>> Cc:	target-devel@xxxxxxxxxxxxxxx
>> Cc:	Sagi Grimberg <sagi@xxxxxxxxxxx>
>> Cc:	linux-rdma@xxxxxxxxxxxxxxx
>> Cc:	"James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>
>> Cc:	"Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
> 
>      ^^^ checkpatch complains about these spaces.

Hah, those are tabs, not spaces.

scripts/checkpatch.pl (comment) says something about this being a style thing:
# Check signature styles

WARNING: Use a single space after Cc:
#29: 
Cc:	"Martin K. Petersen" <martin.petersen@xxxxxxxxxx>



Email standards (RFCs) sure don't require a single space.

and I would like to be able to copy N lines from MAINTAINERS file and then
replace either the M: and/or L: (actually just the 'M' or 'L') with
"To" or "Cc" and be done with it, instead of having to replace TAB on each
line with a space also.

Does anyone know where this "signature style" check came from?
I don't see it in any style guide.

thanks,
-- 
~Randy



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux