On 12/27, Greg Kroah-Hartman wrote: > On Wed, Dec 27, 2017 at 09:00:10AM +0000, Avri Altman wrote: > > > > > > > -----Original Message----- > > > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > > > owner@xxxxxxxxxxxxxxx] On Behalf Of Greg Kroah-Hartman > > > Sent: Thursday, December 21, 2017 10:00 AM > > > To: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; Jaegeuk Kim > > > <jaegeuk@xxxxxxxxxx> > > > Subject: Re: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS > > > health info > > > > > > On Wed, Dec 20, 2017 at 02:13:25PM -0800, Jaegeuk Kim wrote: > > > > This patch adds a new sysfs group, namely health, via: > > > > > > > > /sys/devices/soc/X.ufshc/health/ > > As device health is just one piece of information out of the device management, > > I think that you should address this in a more comprehensive way, > > And set hooks for much more device info: > > Allow access to device descriptors, attributes and flags. > > Add on patches are easy to create for this if people really want and > need it :) > > > The attributes and flags should be placed in separate subfolders > > Why? What is that going to help with? > > > The LUN specific descriptors and attributes should be placed in a luns > > subfolder, and then per descriptor / attribute type > > Again, why? > > > You might also would like to consider differentiating read and write - > > to control those type of accesses as well. > > What do you mean by this exactly? > > As it is, this is a step forward in getting attributes that people are > asking for and already using, into the kernel tree. Please don't object > because not all attributes that are possible are being added here, it > should be trivial to add more as needed, right? > > I'm really tired of seeing all of the various out-of-tree forks of this > driver, it's about time that someone works to get those features merged, > right? Indeed, it seems someone has already done similar work before. Let me drop my patches and dive into that, although I have to clean up all the mess once again. :( Thanks, > > thanks, > > greg k-h
