> -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Greg Kroah-Hartman > Sent: Thursday, December 21, 2017 10:00 AM > To: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; Jaegeuk Kim > <jaegeuk@xxxxxxxxxx> > Subject: Re: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS > health info > > On Wed, Dec 20, 2017 at 02:13:25PM -0800, Jaegeuk Kim wrote: > > This patch adds a new sysfs group, namely health, via: > > > > /sys/devices/soc/X.ufshc/health/ As device health is just one piece of information out of the device management, I think that you should address this in a more comprehensive way, And set hooks for much more device info: Allow access to device descriptors, attributes and flags. The attributes and flags should be placed in separate subfolders The LUN specific descriptors and attributes should be placed in a luns subfolder, and then per descriptor / attribute type You might also would like to consider differentiating read and write - to control those type of accesses as well. Cheers, Avri
