On Tue, 15 Aug 2006, Vladislav Bolkhovitin wrote: > Looking at the qla2xxx driver source code I noticed that > scsi_qla_host_t.fcports is used without any protection. For instance, > qla2x00_loop_reset() walks over this list. This function is called from > qla2xxx_eh_bus_reset(), which could be called at any time. What does > protect fcports from being changed, eg, by some async loop event during > the walking and eventually oops'ing? Do I miss something? There are many > such unprotected fcports list usages in the driver. Nothing is ever removed from the fcports list during driver execution. fcports are also only added from a single context (post init-time) within the DPC thread. We are safe here. Regards, Andrew Vasquez - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
