On Thu, Aug 03, 2006 at 08:03:07AM -0700, Mark Haverkamp wrote: > Received from Mark Salyzyn > > The enclosed patch cleans up some code fragments, adds some paranoia > (unproven causes of potential driver failures). > > Signed-off-by: Mark Haverkamp <markh@xxxxxxxx> > --- > > --- scsi-misc-aac.orig/drivers/scsi/aacraid/aachba.c 2006-07-31 14:33:27.000000000 -0700 > +++ scsi-misc-aac/drivers/scsi/aacraid/aachba.c 2006-07-31 14:33:51.000000000 -0700 > @@ -489,6 +489,8 @@ > unsigned instance; > > fsa_dev_ptr = dev->fsa_dev; > + if (!fsa_dev_ptr) > + return -ENOMEM; How could this (and the fsa_dev_ptr in all other places) ever be null? - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html