Hi Ming, On Fri, Sep 01, 2017 at 01:27:23AM +0800, Ming Lei wrote: > - blk_mq_run_hw_queues(q, false); > + if (q->mq_ops) > + blk_mq_run_hw_queues(q, false); What speaks against putting the if (q->mq_ops) directly into blk_mq_run_hw_queues() so we can't accidently call it from the sq path? Just an idea, no hard preferences here. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
