Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
From: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>
Date: Thu, 24 Aug 2017 10:26:19 -0500
Cc: James Smart <james.smart@xxxxxxxxxxxx>, Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <yq1d17ladk5.fsf@oracle.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

Hi Martin,

On 08/23/2017 09:45 PM, Martin K. Petersen wrote:


Gustavo,

Remove variable assignments. The value stored in local variable _rc_
is overwritten at line 2448:rc =
lpfc_sli4_bsg_set_link_diag_state(phba, 0); before it can be used.


Applied to 4.14/scsi-queue. Thank you!


Glad to help. :)

--
Gustavo A. R. Silva

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
  - From: Gustavo A. R. Silva
- Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
  - From: Martin K. Petersen

Prev by Date: Re: [PATCH] Improve requeuing behavior
Next by Date: Re: [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it
Previous by thread: Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
Next by thread: [GIT PULL] SCSI fixes for 4.13-rc6
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux