Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 23 Aug 2017 22:45:46 -0400
Cc: James Smart <james.smart@xxxxxxxxxxxx>, Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20170822205353.GA17794@embeddedgus> (Gustavo A. R. Silva's message of "Tue, 22 Aug 2017 15:53:53 -0500")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Gustavo,

> Remove variable assignments. The value stored in local variable _rc_
> is overwritten at line 2448:rc =
> lpfc_sli4_bsg_set_link_diag_state(phba, 0); before it can be used.

Applied to 4.14/scsi-queue. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
  - From: Gustavo A. R. Silva

References:
- [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
  - From: Gustavo A. R. Silva

Prev by Date: Re: [PATCH] scsi: qedf: Fix a potential NULL pointer dereference
Next by Date: [PATCH] scsi: ufs: reqs and tasks were put in the wrong order
Previous by thread: Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
Next by thread: Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]