Hi Bart,
> On Jul 11, 2017, at 5:39 PM, Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, 2017-07-11 at 23:43 +0000, Bart Van Assche wrote:
>> On Tue, 2017-06-13 at 20:47 -0700, Himanshu Madhani wrote:
>>> typedef struct srb {
>>> + /*
>>> + * Do not move cmd_type field, it needs to
>>> + * line up with qla_tgt_cmd->cmd_type
>>> + */
>>> + uint8_t cmd_type;
>>> + uint8_t pad[3];
>>
>> Hello Himanshu,
>>
>> Had I understood correctly that you had promised to rework the command
>> array merging such that a union is used instead of requiring certain
>> fields to be present at certain offsets (see also
>> https://www.spinics.net/lists/target-devel/msg15591.html)?
>>
>
> Yeah, as discussed previously it was not a blocker for merge.
>
I had mentioned in my v2 submission cover letter that we will submit new patch to
address your review comment.
Since we are in merge window right now i have not posted this patch. As soon as 4.13.0-rc1 is out,
i will submit patch addressing your review comment.
Thanks,
- Himanshu
