On Tue, 2017-06-13 at 20:47 -0700, Himanshu Madhani wrote: > typedef struct srb { > + /* > + * Do not move cmd_type field, it needs to > + * line up with qla_tgt_cmd->cmd_type > + */ > + uint8_t cmd_type; > + uint8_t pad[3]; Hello Himanshu, Had I understood correctly that you had promised to rework the command array merging such that a union is used instead of requiring certain fields to be present at certain offsets (see also https://www.spinics.net/lists/target-devel/msg15591.html)? Bart.