> On Jun 19, 2017, at 1:20 AM, Johannes Thumshirn <jthumshirn@xxxxxxx> wrote: > > On Fri, Jun 16, 2017 at 03:47:40PM -0700, Himanshu Madhani wrote: >> From: Duane Grigsby <duane.grigsby@xxxxxxxxxx> >> >> Signed-off-by: Darren Trapp <darren.trapp@xxxxxxxxxx> >> Signed-off-by: Duane Grigsby <duane.grigsby@xxxxxxxxxx> >> Signed-off-by: Anil Gurumurthy <anil.gurumurhty@xxxxxxxxxx> >> Signed-off-by: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx> >> Signed-off-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> >> --- > > [...] > >> +static void >> +qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, void *tsk) >> +{ >> + const char func[] = "NVME-IOCB"; >> + fc_port_t *fcport; >> + srb_t *sp; >> + struct srb_iocb *iocb; >> + struct sts_entry_24xx *sts = (struct sts_entry_24xx *)tsk; > > No need to cast from void* > > Thanks for Review. will fix this in v2. > Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> > > > -- > Johannes Thumshirn Storage > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 Thanks, - Himanshu