Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Jun 19, 2017, at 1:09 AM, Johannes Thumshirn <jthumshirn@xxxxxxx> wrote:
> 
> On Fri, Jun 16, 2017 at 03:47:39PM -0700, Himanshu Madhani wrote:
>> From: Duane Grigsby <duane.grigsby@xxxxxxxxxx>
>> 
>> Signed-off-by: Darren Trapp <darren.trapp@xxxxxxxxxx>
>> Signed-off-by: Duane Grigsby <duane.grigsby@xxxxxxxxxx>
>> Signed-off-by: Anil Gurumurthy <anil.gurumurhty@xxxxxxxxxx>
>> Signed-off-by: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx>
>> Signed-off-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
>> ---
> 
> [...]
> 
>> +
>> +	if ((fcport->fw_login_state == DSC_LS_PLOGI_PEND) ||
>> +	    (fcport->fw_login_state == DSC_LS_PLOGI_COMP) ||
>> +	    (fcport->fw_login_state == DSC_LS_PRLI_PEND))
>> +		return rval;
> 
> Minor nit, superfluous parenthesis.
> 
> 

Will fix it in v2

> Anyways,
> Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> 
> -- 
> Johannes Thumshirn                                          Storage
> jthumshirn@xxxxxxx                                +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Thanks,
- Himanshu





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux