On Sun, 2017-05-21 at 08:51 +0200, Christoph Hellwig wrote: > On Fri, May 19, 2017 at 11:30:13AM -0700, Bart Van Assche wrote: > > The storvsc driver is the only SCSI LLD that uses driver-private > > command data and that does not zero-initialize that data before > > reading it. Make this driver consistent with the other SCSI LLDs > > that use driver-private command data. > > Well. Either we add zeroing to storvsc and remove it from common > code, or we remove the zeroing from the drivers. > > We shouldn't do both. Given that we already zero the remaining > command it seems to me like keeping the zeroing in common code > would be preferred, but I'm open to discussion. Hello Christoph, I will remove the code that zeroes driver-private command data from the other SCSI LLDs and add it to the scsi-sq request preparation code path. Bart.
