Christoph, > Normally we'd just pass the scsi_sense_hdr structure in from the caler > if we care about sense data. Is this something you considered? > > Otherwise this looks fine to me. I agree with Christoph that passing the sense header would be more consistent with the rest of the SCSI code. Even if we only need the key in this case. -- Martin K. Petersen Oracle Linux Engineering