On 05/05/2017 11:02, Christoph Hellwig wrote:
Not really as only the sense_key field is needed for only one call to sd_sync_cache() (out of two).Normally we'd just pass the scsi_sense_hdr structure in from the caler if we care about sense data. Is this something you considered?
Otherwise this looks fine to me.