> -----Original Message----- > From: Bart Van Assche [mailto:Bart.VanAssche@xxxxxxxxxxx] > Sent: Tuesday, April 25, 2017 3:13 PM > To: hch@xxxxxxxxxxxxx; Viswas G <viswas.g@xxxxxxxxxxxxx>; Gerry > Morong <gerry.morong@xxxxxxxxxxxxx>; Mahesh Rajashekhara > <mahesh.rajashekhara@xxxxxxxxxxxxx>; POSWALD@xxxxxxxx; Scott > Benesh <scott.benesh@xxxxxxxxxxxxx>; Don Brace > <don.brace@xxxxxxxxxxxxx>; Bader Ali - Saleh > <bader.alisaleh@xxxxxxxxxxxxx>; Kevin Barnett > <kevin.barnett@xxxxxxxxxxxxx>; joseph.szczypek@xxxxxxx; Scott Teel > <scott.teel@xxxxxxxxxxxxx>; jejb@xxxxxxxxxxxxxxxxxx; Justin Lindley > <justin.lindley@xxxxxxxxxxxxx>; John Hall <John.Hall@xxxxxxxxxxxxx> > Cc: linux-scsi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 20/37] smartpqi: add ptraid support > > EXTERNAL EMAIL > > > On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote: > > +static inline bool pqi_is_external_raid_device(struct pqi_scsi_dev > *device) > > +{ > > + return device->is_external_raid_device; > > +} > > The name of this function is almost as long as its implementation. Please drop > this function definition and inline the function into its callers. > > Thanks, > > Bart. Done Thanks, Don Brace ESC - Smart Storage Microsemi Corporation
