On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote: > +static inline bool pqi_is_external_raid_device(struct pqi_scsi_dev *device) > +{ > + return device->is_external_raid_device; > +} The name of this function is almost as long as its implementation. Please drop this function definition and inline the function into its callers. Thanks, Bart.