> -----Original Message----- > From: Hannes Reinecke [mailto:hare@xxxxxxxx] > Sent: Tuesday, March 07, 2017 9:25 AM > To: Don Brace <don.brace@xxxxxxxxxxxxx>; Hannes Reinecke > <hare@xxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx>; James Bottomley > <james.bottomley@xxxxxxxxxxxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx > Subject: Re: [PATCHv2] hpsa: expose enclosures > > EXTERNAL EMAIL > > > On 03/07/2017 04:05 PM, Don Brace wrote: > >> -----Original Message----- > >> From: Hannes Reinecke [mailto:hare@xxxxxxx] > >> Sent: Thursday, February 23, 2017 4:55 AM > >> To: Martin K. Petersen <martin.petersen@xxxxxxxxxx> > >> Cc: Christoph Hellwig <hch@xxxxxx>; James Bottomley > >> <james.bottomley@xxxxxxxxxxxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; > >> Hannes Reinecke <hare@xxxxxxx>; Don Brace > >> <don.brace@xxxxxxxxxxxxx>; Hannes Reinecke <hare@xxxxxxxx> > >> Subject: [PATCHv2] hpsa: expose enclosures > >> > >> EXTERNAL EMAIL > >> > >> > >> Some servers have a built-in enclosure which will show up on the > >> same bus as the internal physical devices. This patch fixes the > >> driver to expose them. > >> > >> Cc: Don Brace <don.brace@xxxxxxxxxxxxx> > >> Signed-off-by: Hannes Reinecke <hare@xxxxxxxx> > > > > Masking various SES targets is a conscious choice, not a design oversight. > > So, I have to decline this patch., > > > Would you be okay with a module parameter for this? > It really feels stupid to present the user with an enclosure device > during boot (as hpsa presents all physical LUNs during booting), but not > exporting it to the user. > > Cheers, > > Hannes We would not be able to support this as it can cause issues with LED management. A customer could pull the wrong drive and lose data because the LED state was incorrect. That results in support issues. We like to show the enclosures even if masked as it helps with diagnosing problems. Thanks, Don Brace ESC - Smart Storage Microsemi Corporation > -- > Dr. Hannes Reinecke zSeries & Storage > hare@xxxxxxxx +49 911 74053 688 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg)
