RE: [PATCHv2] hpsa: expose enclosures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@xxxxxxx]
> Sent: Thursday, February 23, 2017 4:55 AM
> To: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>; James Bottomley
> <james.bottomley@xxxxxxxxxxxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx;
> Hannes Reinecke <hare@xxxxxxx>; Don Brace
> <don.brace@xxxxxxxxxxxxx>; Hannes Reinecke <hare@xxxxxxxx>
> Subject: [PATCHv2] hpsa: expose enclosures
> 
> EXTERNAL EMAIL
> 
> 
> Some servers have a built-in enclosure which will show up on the
> same bus as the internal physical devices. This patch fixes the
> driver to expose them.
> 
> Cc: Don Brace <don.brace@xxxxxxxxxxxxx>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>

Masking various SES targets is a conscious choice, not a design oversight.
So, I have to decline this patch.,

Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation

> ---
>  drivers/scsi/hpsa.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 524a0c7..a77ed5a 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -4407,7 +4407,10 @@ static void hpsa_update_scsi_devices(struct
> ctlr_info *h)
>                  * Expose all devices except for physical devices that
>                  * are masked.
>                  */
> -               if (MASKED_DEVICE(lunaddrbytes) && this_device-
> >physical_device)
> +               if (this_device->devtype == TYPE_ENCLOSURE)
> +                       this_device->expose_device = 1;
> +               else if (MASKED_DEVICE(lunaddrbytes) &&
> +                        this_device->physical_device)
>                         this_device->expose_device = 0;
>                 else
>                         this_device->expose_device = 1;
> --
> 1.8.5.6





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux