On 15/02/2017 05:06, Ram Pai wrote: > On Wed, Feb 15, 2017 at 03:48:52PM +0900, Damien Le Moal wrote: >> Christoph, >> >> On 2/15/17 15:34, Christoph Hellwig wrote: >>> this looks reasonable, but we should ask Guilherme and Ram to confirm >>> it fixes their originally reported issue. I've added them to Cc. >> >> Thank you. >> >> Guilherme, Ram, >> >> Please test ! The original fix breaks the zoned block device support >> that was newly added to 4.10. So we need a fix for that and your issue >> combined before Linus releases 4.10 stable this weekend. > > Yes logically it looks correct and should fix our issue. > > I doubt Guilherme has access to the same adapter firmware that exposed > the original problem. We will probably have to induce the erroneous > behavior in the driver to reproduce the issue and verify the fix. Ram, I do have access but the environment changed a lot, including disks, setup of the distributed filesystem and tests...and so I wasn't able to reproduce the issue anymore. Since the logic of the new approach looks correct, I'm ok with the patch. Thanks, Guilherme > > Will let you know, > RP >
