On 02/08/2017 08:13 PM, James Smart wrote: > > On 2/8/2017 4:47 AM, Christoph Hellwig wrote: >> On Tue, Feb 07, 2017 at 06:32:30PM -0800, James Smart wrote: >>> I realize I cut these in a silly way. In the v1 patches, I had a big >>> patch >>> that I then cut into 6 parts, by file. In the v2 patches, I tried to >>> keep >>> the patches as is, and address the comments in the respective patch the >>> comment came from. Which resulted in 3/8 with an old reference, but >>> patch >>> 8/8 being the one that reverted this reverence. Sorry.. I'll recut and >>> repost. >> This whole split doesn't make sense - either the patches are logically >> split, in which case they can be posted separately, or they belong >> together in which case they should be sent together. But the size >> of them suggest to me they probably need to be broken down to logically >> separate patches. >> >> And can you please switch to using git-send-email to send the patches >> straight from a git branch? There are lot of patch formatting issues >> with the lpfc patches, and that should fix most of them instantly. >> > > Ok. I will see if they can be further split. I don't have a lot of hope > beyond a couple splits. So, the resulting patches will be large. > Unfortunate, but should be okay. We've reviewed the bulk of the patches already, so we'll live with that. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
