On Wed, Dec 28, 2016 at 4:35 PM, ojab <ojab@xxxxxxx> wrote: > MPI2 controllers sometimes got lost (i. e. disappears from > /sys/bus/pci/devices) if ASMP is enabled. > > Signed-off-by: Slava Kardakov <ojab@xxxxxxx> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=60644 >From some of our system engineers team, I came to known that ASPM needs to be disabled. So this patch looks good. Please consider this patch as Acked-by: Sreekanth Reddy <Sreekanth.Reddy@xxxxxxxxxxxx> Thanks, Sreekanth > --- > V2: use name in Signed-off-by > > Not sure if it's a complete fix, but at least I can't reproduce the issue > locally with it applied. > > Also it's my first patch, so I've surely screwed up some formatting etc. > > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index b5c966e..203651a 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -51,6 +51,7 @@ > #include <linux/workqueue.h> > #include <linux/delay.h> > #include <linux/pci.h> > +#include <linux/pci-aspm.h> > #include <linux/interrupt.h> > #include <linux/aer.h> > #include <linux/raid_class.h> > @@ -8734,6 +8735,8 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id) > > switch (hba_mpi_version) { > case MPI2_VERSION: > + pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | > + PCIE_LINK_STATE_L1 | PCIE_LINK_STATE_CLKPM); > /* Use mpt2sas driver host template for SAS 2.0 HBA's */ > shost = scsi_host_alloc(&mpt2sas_driver_template, > sizeof(struct MPT3SAS_ADAPTER)); > -- > 2.10.0 > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
