> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@xxxxxxxx] > Sent: Tuesday, February 7, 2017 5:00 AM > To: dl-esc-Aacraid Linux Driver <aacraid@xxxxxxxxxxxxx>; James E.J. > Bottomley <jejb@xxxxxxxxxxxxxxxxxx>; Martin K. Petersen > <martin.petersen@xxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx>; Johannes Thumshirn > <jthumshirn@xxxxxxx>; Raghava Aditya Renukunta > <RaghavaAditya.Renukunta@xxxxxxxxxxxxx>; Dave Carroll > <david.carroll@xxxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits > > EXTERNAL EMAIL > > > Shifting a dma_addr_t right by 32 bits causes a compile-time warning when > that type is only 32 bit wide: > > drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter': > drivers/scsi/aacraid/src.c:414:29: error: right shift count >= width of type [- > Werror=shift-count-overflow] > > This changes the driver to use the predefined macros consistently, including > one correct but open-coded upper_32_bits() instance. > > Fixes: d1ef4da8487f ("scsi: aacraid: added support for init_struct_8") > Fixes: 423400e64d37 ("scsi: aacraid: Include HBA direct interface") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@xxxxxxxxxxxxx>
