> -----Original Message----- > From: Colin King [mailto:colin.king@xxxxxxxxxxxxx] > Sent: Tuesday, February 7, 2017 3:51 AM > To: dl-esc-Aacraid Linux Driver <aacraid@xxxxxxxxxxxxx>; James E . J . > Bottomley <jejb@xxxxxxxxxxxxxxxxxx>; Martin K . Petersen > <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int > > EXTERNAL EMAIL > > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > aac_fib_send can return -ve error returns and hence rcode should > be signed. Currently the rcode >= 0 check is always true and -ve > errors are not being checked. > > Thanks to Dan Carpenter for spotting my original broken fix to this > issue. > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@xxxxxxxxxxxxx>
