Re: [PATCH 26/39] megaraid_sas: max_fw_cmds are decremented twice, remove duplicate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/06/2017 10:59 AM, Shivasharan S wrote:
> Fix to account for the reply_q_sz not exceeding
> the maximum commands that the firmware can support,
> instance->max_fw_cmds is already decremented in
> megasas_fusion_update_can_queue().
> Remove the extra decrement logic in code.
> 
> Signed-off-by: Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>
> Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@xxxxxxxxxxxx>
> ---
>  drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 2bfdf6b..e74cbe6d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -1282,13 +1282,6 @@ megasas_init_adapter_fusion(struct megasas_instance *instance)
>  	megasas_fusion_update_can_queue(instance, PROBE_CONTEXT);
>  
>  	/*
> -	 * Reduce the max supported cmds by 1. This is to ensure that the
> -	 * reply_q_sz (1 more than the max cmd that driver may send)
> -	 * does not exceed max cmds that the FW can support
> -	 */
> -	instance->max_fw_cmds = instance->max_fw_cmds-1;
> -
> -	/*
>  	 * Only Driver's internal DCMDs and IOCTL DCMDs needs to have MFI frames
>  	 */
>  	instance->max_mfi_cmds =
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@xxxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux