On 02/06/2017 10:59 AM, Shivasharan S wrote:
> Minor Optimization: No need to update HBA can_queue value
> if the current max FW commands is equal to earlier value.
>
> Signed-off-by: Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>
> Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@xxxxxxxxxxxx>
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 22965b6..2bfdf6b 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -259,7 +259,7 @@ megasas_fusion_update_can_queue(struct megasas_instance *instance, int fw_boot_c
>
> if (fw_boot_context == OCR_CONTEXT) {
> cur_max_fw_cmds = cur_max_fw_cmds - 1;
> - if (cur_max_fw_cmds <= instance->max_fw_cmds) {
> + if (cur_max_fw_cmds < instance->max_fw_cmds) {
> instance->cur_can_queue =
> cur_max_fw_cmds - (MEGASAS_FUSION_INTERNAL_CMDS +
> MEGASAS_FUSION_IOCTL_CMDS);
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
