On 02/01/2017 02:03 PM, Christoph Hellwig wrote: > On Wed, Feb 01, 2017 at 02:00:48PM +0100, Christoph Hellwig wrote: >> I think the proper fix is to check sfp->low_dma for 0 before updating >> it, at least that seems to be the intent here. > > Looking at this code a bit more I think the actual, real proper fix > is to remove the SET_FORCE_LOW_DMA entirely (except maybe the flag > for SG_GET_LOW_DMA and procfs output). The block layer already does > bounce buffering if the DMA addressing constraints are not met, > so all this should just go away. > Oh, I'm more than happy to do so. > Btw, any rason Doug isn't on Cc on these sg.c patches? > None. Oversight from my side. Will be sending a v2 with those two patches rolled into one patchset. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
