Re: [PATCH] sg: remove unreachable code in SET_FORCE_LOW_DMA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 01, 2017 at 02:00:48PM +0100, Christoph Hellwig wrote:
> I think the proper fix is to check sfp->low_dma for 0 before updating
> it, at least that seems to be the intent here.

Looking at this code a bit more I think the actual, real proper fix
is to remove the SET_FORCE_LOW_DMA entirely (except maybe the flag
for SG_GET_LOW_DMA and procfs output).  The block layer already does
bounce buffering if the DMA addressing constraints are not met,
so all this should just go away.

Btw, any rason Doug isn't on Cc on these sg.c patches?




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux