[bug report] [SCSI] mpt3sas: add new driver supporting 12GB SAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Sreekanth Reddy,

The patch f92363d12359: "[SCSI] mpt3sas: add new driver supporting
12GB SAS" from Nov 30, 2012, leads to the following static checker
warning:

	drivers/scsi/mpt3sas/mpt3sas_base.c:620 _base_display_event_data()
	warn: curly braces intended?

drivers/scsi/mpt3sas/mpt3sas_base.c
   610          case MPI2_EVENT_SAS_DISCOVERY:
   611          {
   612                  Mpi2EventDataSasDiscovery_t *event_data =
   613                      (Mpi2EventDataSasDiscovery_t *)mpi_reply->EventData;
   614                  pr_info(MPT3SAS_FMT "Discovery: (%s)", ioc->name,
   615                      (event_data->ReasonCode == MPI2_EVENT_SAS_DISC_RC_STARTED) ?
   616                      "start" : "stop");
   617                  if (event_data->DiscoveryStatus)
   618                          pr_info("discovery_status(0x%08x)",
   619                              le32_to_cpu(event_data->DiscoveryStatus));
   620                          pr_info("\n");

The indenting is messed up here and also this should be using pr_cont()
because pr_info() will put a bunch of crap in the middle of the line.

   621                  return;
   622          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux